fix "no constructor defined" messages on PyPy #5329
Merged
+15
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
changed the title
Icxolu
approved these changes
Aug 24, 2025
src/pyclass/create_type_object.rs
Outdated
| /// Default new implementation | ||
| #[cfg(not(all(Py_3_10, not(PyPy))))] | ||
| /// Default new implementation, to match | ||
| /// <https://github.com/python/cpython/blob/3663b2ad54c9e15775a605facf69da8f5ee8d335/Objects/typeobject.c#L2427-L2428> |
There was a problem hiding this comment.
Not sure if this comment still makes sense. I guess the output should be identical still..
Also I think the #[cfg(not(PyPy))] in the trampoline below needs to go now, because PyPy does the same thing as CPython now, right?
There was a problem hiding this comment.
Thanks for catching, sorry for my shoddy patch 😂
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
* fix "cannot create '%s' instances" message to match CPython * don't use unlimited C API directly * review feedback * fixup * fixup xfail on PyPy
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been fixed upstream, let's simplify and xfail for now, the next PyPy patch release will fix this.